From c9e821e93e19d3a11233486b3c62548e9f128b24 Mon Sep 17 00:00:00 2001 From: David <25727384+ogniK5377@users.noreply.github.com> Date: Tue, 26 Jun 2018 00:34:41 +1000 Subject: [PATCH 1/2] Send the correct RequestUpdateAudioRenderer revision in the output header (#587) * We should be returning our revision instead of what is requested. Hardware test on a 5.1.0 console * Added sysversion comment --- src/core/hle/service/audio/audren_u.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/hle/service/audio/audren_u.cpp b/src/core/hle/service/audio/audren_u.cpp index 2188b56259..3dfb3fb52b 100644 --- a/src/core/hle/service/audio/audren_u.cpp +++ b/src/core/hle/service/audio/audren_u.cpp @@ -150,7 +150,7 @@ private: UpdateDataHeader() {} UpdateDataHeader(const AudioRendererParameter& config) { - revision = config.revision; + revision = Common::MakeMagic('R', 'E', 'V', '4'); // 5.1.0 Revision behavior_size = 0xb0; memory_pools_size = (config.effect_count + (config.voice_count * 4)) * 0x10; voices_size = config.voice_count * 0x10; From ad39bab2710bd29493ba62aead9e0a72ea1815c4 Mon Sep 17 00:00:00 2001 From: mailwl Date: Mon, 25 Jun 2018 18:01:08 +0300 Subject: [PATCH 2/2] Fix crash at exit --- src/video_core/debug_utils/debug_utils.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/video_core/debug_utils/debug_utils.h b/src/video_core/debug_utils/debug_utils.h index bbba8e3807..9382a75e57 100644 --- a/src/video_core/debug_utils/debug_utils.h +++ b/src/video_core/debug_utils/debug_utils.h @@ -55,8 +55,10 @@ public: virtual ~BreakPointObserver() { auto context = context_weak.lock(); if (context) { - std::unique_lock lock(context->breakpoint_mutex); - context->breakpoint_observers.remove(this); + { + std::unique_lock lock(context->breakpoint_mutex); + context->breakpoint_observers.remove(this); + } // If we are the last observer to be destroyed, tell the debugger context that // it is free to continue. In particular, this is required for a proper yuzu