settings: move use_docked_mode to Controls group

`use_docked_mode` is set in the input settings and cannot be accessed from the
system settings. Grouping it with system settings causes it to be saved with
per-game settings, which may make transferring configs more difficult later on,
especially since docked mode cannot be set from within the game properties
dialog.

src/core/frontend/framebuffer_layout.cpp

@@ -47,7 +47,7 @@ FramebufferLayout DefaultFrameLayout(u32 width, u32 height) {
 FramebufferLayout FrameLayoutFromResolutionScale(u32 res_scale) {
     u32 width, height;
 
-    if (Settings::values->use_docked_mode) {
+    if (Settings::base_values.use_docked_mode) {
         width = ScreenDocked::Width * res_scale;
         height = ScreenDocked::Height * res_scale;
     } else {

src/core/hle/service/am/am.cpp

@@ -729,7 +729,7 @@ void ICommonStateGetter::GetDefaultDisplayResolution(Kernel::HLERequestContext&
     IPC::ResponseBuilder rb{ctx, 4};
     rb.Push(RESULT_SUCCESS);
 
-    if (Settings::values->use_docked_mode) {
+    if (Settings::base_values.use_docked_mode) {
         rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedWidth) *
                 static_cast<u32>(Settings::values->resolution_factor));
         rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedHeight) *
@@ -802,7 +802,7 @@ void IStorage::Open(Kernel::HLERequestContext& ctx) {
 }
 
 void ICommonStateGetter::GetOperationMode(Kernel::HLERequestContext& ctx) {
-    const bool use_docked_mode{Settings::values->use_docked_mode};
+    const bool use_docked_mode{Settings::base_values.use_docked_mode};
     LOG_DEBUG(Service_AM, "called, use_docked_mode={}", use_docked_mode);
 
     IPC::ResponseBuilder rb{ctx, 3};

src/core/hle/service/apm/controller.cpp

@@ -69,7 +69,7 @@ void Controller::SetFromCpuBoostMode(CpuBoostMode mode) {
 }
 
 PerformanceMode Controller::GetCurrentPerformanceMode() const {
-    return Settings::values->use_docked_mode ? PerformanceMode::Docked : PerformanceMode::Handheld;
+    return Settings::base_values.use_docked_mode ? PerformanceMode::Docked : PerformanceMode::Handheld;
 }
 
 PerformanceConfiguration Controller::GetCurrentPerformanceConfiguration(PerformanceMode mode) {

src/core/hle/service/hid/controllers/npad.cpp

@@ -685,7 +685,7 @@ bool Controller_NPad::IsControllerSupported(NPadControllerType controller) const
             return false;
         }
         // Handheld should not be supported in docked mode
-        if (Settings::values->use_docked_mode) {
+        if (Settings::base_values.use_docked_mode) {
             return false;
         }
 
@@ -718,7 +718,7 @@ Controller_NPad::NPadControllerType Controller_NPad::DecideBestController(
     if (IsControllerSupported(priority)) {
         return priority;
     }
-    const auto is_docked = Settings::values->use_docked_mode;
+    const auto is_docked = Settings::base_values.use_docked_mode;
     if (is_docked && priority == NPadControllerType::Handheld) {
         priority = NPadControllerType::JoyDual;
         if (IsControllerSupported(priority)) {

src/core/hle/service/vi/vi.cpp

@@ -746,7 +746,7 @@ private:
         IPC::ResponseBuilder rb{ctx, 6};
         rb.Push(RESULT_SUCCESS);
 
-        if (Settings::values->use_docked_mode) {
+        if (Settings::base_values.use_docked_mode) {
             rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedWidth) *
                     static_cast<u32>(Settings::values->resolution_factor));
             rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedHeight) *

src/core/settings.cpp

@@ -176,7 +176,7 @@ void LogSetting(const std::string& name, const T& value) {
 
 void LogSettings() {
     LOG_INFO(Config, "yuzu Configuration:");
-    LogSetting("System_UseDockedMode", Settings::values->use_docked_mode);
+    LogSetting("System_UseDockedMode", Settings::base_values.use_docked_mode);
     LogSetting("System_RngSeed", Settings::values->rng_seed.value_or(0));
     LogSetting("System_CurrentUser", Settings::values->current_user);
     LogSetting("System_LanguageIndex", Settings::values->language_index);

src/core/settings.h

@@ -420,7 +420,6 @@ struct Values {
     float bg_blue;
 
     // System
-    bool use_docked_mode;
     std::optional<u32> rng_seed;
     // Measured in seconds since epoch
     std::optional<std::chrono::seconds> custom_rtc;
@@ -457,6 +456,8 @@ struct NonSwitchingValues {
     u16 udp_input_port;
     u8 udp_pad_index;
 
+    bool use_docked_mode;
+
     // Data Storage
     bool use_virtual_sd;
     bool gamecard_inserted;

src/core/telemetry_session.cpp

@@ -203,7 +203,7 @@ void TelemetrySession::AddInitialInfo(Loader::AppLoader& app_loader) {
              Settings::values->use_asynchronous_gpu_emulation);
     AddField(field_type, "Renderer_UseVsync", Settings::values->use_vsync);
     AddField(field_type, "Renderer_UseAssemblyShaders", Settings::values->use_assembly_shaders);
-    AddField(field_type, "System_UseDockedMode", Settings::values->use_docked_mode);
+    AddField(field_type, "System_UseDockedMode", Settings::base_values.use_docked_mode);
 }
 
 bool TelemetrySession::SubmitTestcase() {