From e555fc3552f8fa6d73463b939123d6fea9276913 Mon Sep 17 00:00:00 2001 From: Khangaroo Date: Fri, 10 Aug 2018 17:03:52 -0400 Subject: [PATCH 1/2] Prevent PixelFormatFromRenderTargetFormat from returning an uninitialized value --- src/video_core/renderer_opengl/gl_rasterizer_cache.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.h b/src/video_core/renderer_opengl/gl_rasterizer_cache.h index 829a76dfe4..eb85ebe9ad 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer_cache.h +++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.h @@ -250,6 +250,7 @@ struct SurfaceParams { default: LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast(format)); UNREACHABLE(); + return PixelFormat::ABGR8U; } } From ab027331b9c2ca9915559c1c1adaa27bc2f32d1b Mon Sep 17 00:00:00 2001 From: Khangaroo Date: Fri, 10 Aug 2018 17:33:02 -0400 Subject: [PATCH 2/2] oops --- src/video_core/renderer_opengl/gl_rasterizer_cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.h b/src/video_core/renderer_opengl/gl_rasterizer_cache.h index eb85ebe9ad..b5df09752b 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer_cache.h +++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.h @@ -250,7 +250,7 @@ struct SurfaceParams { default: LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast(format)); UNREACHABLE(); - return PixelFormat::ABGR8U; + return PixelFormat::ABGR8; } }