prifak/yuzu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

common/hex_util: Apply nodiscard where applicable

Browse Source 
Applies nodiscard to functions where ignoring the return value would be
a bug.
This commit is contained in:
Lioncash
2019-04-15 12:57:07 -04:00
parent 016a647623
commit 4ddf95aba0
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/common/hex_util.h
View File

@@ -13,12 +13,12 @@
namespace Common { namespace Common {
u8 ToHexNibble(char c1); [[nodiscard]] u8 ToHexNibble(char c1);
std::vector<u8> HexStringToVector(std::string_view str, bool little_endian); [[nodiscard]] std::vector<u8> HexStringToVector(std::string_view str, bool little_endian);
template <std::size_t Size, bool le = false> template <std::size_t Size, bool le = false>
std::array<u8, Size> HexStringToArray(std::string_view str) { [[nodiscard]] std::array<u8, Size> HexStringToArray(std::string_view str) {
std::array<u8, Size> out{}; std::array<u8, Size> out{};
if constexpr (le) { if constexpr (le) {
for (std::size_t i = 2 * Size - 2; i <= 2 * Size; i -= 2) for (std::size_t i = 2 * Size - 2; i <= 2 * Size; i -= 2)
@@ -30,17 +30,17 @@ std::array<u8, Size> HexStringToArray(std::string_view str) {
return out; return out;
} }
std::string HexVectorToString(const std::vector<u8>& vector, bool upper = true); [[nodiscard]] std::string HexVectorToString(const std::vector<u8>& vector, bool upper = true);
template <std::size_t Size> template <std::size_t Size>
std::string HexArrayToString(std::array<u8, Size> array, bool upper = true) { [[nodiscard]] std::string HexArrayToString(std::array<u8, Size> array, bool upper = true) {
std::string out; std::string out;
for (u8 c : array) for (u8 c : array)
out += fmt::format(upper ? "{:02X}" : "{:02x}", c); out += fmt::format(upper ? "{:02X}" : "{:02x}", c);
return out; return out;
} }
std::array<u8, 0x10> operator"" _array16(const char* str, std::size_t len); [[nodiscard]] std::array<u8, 0x10> operator"" _array16(const char* str, std::size_t len);
std::array<u8, 0x20> operator"" _array32(const char* str, std::size_t len); [[nodiscard]] std::array<u8, 0x20> operator"" _array32(const char* str, std::size_t len);
} // namespace Common } // namespace Common