diff --git a/.gitmodules b/.gitmodules index 2ec9dda62a..2ee3d3f969 100644 --- a/.gitmodules +++ b/.gitmodules @@ -31,3 +31,6 @@ [submodule "xbyak"] path = externals/xbyak url = https://github.com/herumi/xbyak.git +[submodule "opus"] + path = externals/opus + url = https://github.com/xiph/opus diff --git a/CMakeLists.txt b/CMakeLists.txt index a9f669d568..43bf789fe6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -157,8 +157,6 @@ macro(yuzu_find_packages) #"libzip 1.5 libzip/1.5.2@bincrafters/stable" "lz4 1.8 lz4/1.9.2" "nlohmann_json 3.7 nlohmann_json/3.7.3" - # we need to be careful as the version check might be broken https://github.com/xiph/opus/issues/110 - "opus 1.3 opus/1.3.1" "ZLIB 1.2 zlib/1.2.11" "zstd 1.4 zstd/1.4.4" ) diff --git a/externals/CMakeLists.txt b/externals/CMakeLists.txt index df7a5e0a94..0744768e11 100644 --- a/externals/CMakeLists.txt +++ b/externals/CMakeLists.txt @@ -41,6 +41,10 @@ target_include_directories(unicorn-headers INTERFACE ./unicorn/include) # SoundTouch add_subdirectory(soundtouch) +# Opus +add_subdirectory(opus) +target_include_directories(opus INTERFACE ./opus/include) + # Cubeb if(ENABLE_CUBEB) set(BUILD_TESTS OFF CACHE BOOL "") diff --git a/externals/find-modules/Findopus.cmake b/externals/find-modules/Findopus.cmake deleted file mode 100644 index de84bd9953..0000000000 --- a/externals/find-modules/Findopus.cmake +++ /dev/null @@ -1,42 +0,0 @@ - -find_package(PkgConfig QUIET) -pkg_check_modules(PC_opus QUIET opus) - -find_path(opus_INCLUDE_DIR - NAMES opus.h - PATHS ${PC_opus_INCLUDE_DIRS} - PATH_SUFFIXES opus -) -find_library(opus_LIBRARY - NAMES opus - PATHS ${PC_opus_LIBRARY_DIRS} -) - -include(FindPackageHandleStandardArgs) -find_package_handle_standard_args(opus - FOUND_VAR opus_FOUND - REQUIRED_VARS - opus_LIBRARY - opus_INCLUDE_DIR - VERSION_VAR opus_VERSION -) - -if(opus_FOUND) - set(Opus_LIBRARIES ${opus_LIBRARY}) - set(Opus_INCLUDE_DIRS ${opus_INCLUDE_DIR}) - set(Opus_DEFINITIONS ${PC_opus_CFLAGS_OTHER}) -endif() - -if(opus_FOUND AND NOT TARGET Opus::Opus) - add_library(Opus::Opus UNKNOWN IMPORTED) - set_target_properties(Opus::Opus PROPERTIES - IMPORTED_LOCATION "${opus_LIBRARY}" - INTERFACE_COMPILE_OPTIONS "${PC_opus_CFLAGS_OTHER}" - INTERFACE_INCLUDE_DIRECTORIES "${opus_INCLUDE_DIR}" - ) -endif() - -mark_as_advanced( - opus_INCLUDE_DIR - opus_LIBRARY -) diff --git a/externals/opus b/externals/opus new file mode 160000 index 0000000000..fad505e8ed --- /dev/null +++ b/externals/opus @@ -0,0 +1 @@ +Subproject commit fad505e8ed6190062515668e3a480ada583e1637 diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 47418006b2..4e8515a0f1 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -606,7 +606,7 @@ endif() create_target_directory_groups(core) target_link_libraries(core PUBLIC common PRIVATE audio_core video_core) -target_link_libraries(core PUBLIC Boost::boost PRIVATE fmt::fmt nlohmann_json::nlohmann_json mbedtls Opus::Opus unicorn) +target_link_libraries(core PUBLIC Boost::boost PRIVATE fmt::fmt nlohmann_json::nlohmann_json mbedtls opus unicorn) if (YUZU_ENABLE_BOXCAT) target_compile_definitions(core PRIVATE -DYUZU_ENABLE_BOXCAT)