From d51efce54781e71e474f4950ae1325bad21332c3 Mon Sep 17 00:00:00 2001
From: Koitharu <nvasya95@gmail.com>
Date: Sun, 1 Mar 2020 20:56:16 +0200
Subject: [PATCH] Fix manga details list layout

---
 .../ui/main/list/MangaListDetailsHolder.kt    |   1 -
 .../res/layout/item_manga_list_details.xml    | 139 +++++++++---------
 2 files changed, 71 insertions(+), 69 deletions(-)

diff --git a/app/src/main/java/org/koitharu/kotatsu/ui/main/list/MangaListDetailsHolder.kt b/app/src/main/java/org/koitharu/kotatsu/ui/main/list/MangaListDetailsHolder.kt
index f81e9fd3d..a3cd38e86 100644
--- a/app/src/main/java/org/koitharu/kotatsu/ui/main/list/MangaListDetailsHolder.kt
+++ b/app/src/main/java/org/koitharu/kotatsu/ui/main/list/MangaListDetailsHolder.kt
@@ -5,7 +5,6 @@ import android.view.ViewGroup
 import androidx.core.view.isVisible
 import coil.api.load
 import coil.request.RequestDisposable
-import coil.size.Scale
 import kotlinx.android.synthetic.main.item_manga_list_details.*
 import org.koitharu.kotatsu.R
 import org.koitharu.kotatsu.core.model.Manga
diff --git a/app/src/main/res/layout/item_manga_list_details.xml b/app/src/main/res/layout/item_manga_list_details.xml
index 157a4fe1c..2ea389d06 100644
--- a/app/src/main/res/layout/item_manga_list_details.xml
+++ b/app/src/main/res/layout/item_manga_list_details.xml
@@ -11,86 +11,89 @@
 	app:strokeColor="?android:colorControlNormal"
 	app:strokeWidth="1px">
 
-	<RelativeLayout
+	<LinearLayout
 		android:layout_width="match_parent"
-		android:layout_height="match_parent">
+		android:layout_height="match_parent"
+		android:orientation="horizontal">
 
 		<org.koitharu.kotatsu.ui.common.widgets.CoverImageView
 			android:id="@+id/imageView_cover"
 			android:layout_width="wrap_content"
 			android:layout_height="match_parent"
-			android:layout_alignParentStart="true"
-			android:layout_alignParentTop="true"
 			android:orientation="vertical" />
 
-		<TextView
-			android:id="@+id/textView_title"
-			android:layout_width="match_parent"
-			android:layout_height="wrap_content"
-			android:layout_alignParentTop="true"
-			android:layout_marginStart="6dp"
-			android:layout_marginTop="6dp"
-			android:layout_marginEnd="6dp"
-			android:layout_toEndOf="@id/imageView_cover"
-			android:ellipsize="end"
-			android:maxLines="2"
-			android:textAppearance="@style/TextAppearance.MaterialComponents.Body1"
-			tools:text="@tools:sample/lorem[6]" />
-
-		<TextView
-			android:id="@+id/textView_subtitle"
-			android:layout_width="match_parent"
-			android:layout_height="wrap_content"
-			android:layout_above="@id/divider"
-			android:layout_below="@id/textView_title"
-			android:layout_marginStart="6dp"
-			android:layout_marginTop="4dp"
-			android:layout_marginEnd="6dp"
-			android:layout_marginBottom="6dp"
-			android:layout_toEndOf="@id/imageView_cover"
-			android:ellipsize="end"
-			android:maxLines="1"
-			android:textAppearance="@style/TextAppearance.MaterialComponents.Body2"
-			android:textColor="?android:textColorSecondary"
-			tools:text="@tools:sample/lorem[6]" />
-
-		<TextView
-			android:id="@+id/textView_tags"
+		<LinearLayout
 			android:layout_width="match_parent"
 			android:layout_height="match_parent"
-			android:layout_below="@id/divider"
-			android:layout_marginStart="6dp"
-			android:layout_marginEnd="6dp"
-			android:layout_toStartOf="@id/textView_rating"
-			android:layout_toEndOf="@id/imageView_cover"
-			android:ellipsize="none"
-			android:gravity="center_vertical"
-			android:requiresFadingEdge="horizontal"
-			android:singleLine="true" />
+			android:orientation="vertical">
 
-		<TextView
-			android:id="@+id/textView_rating"
-			android:layout_width="wrap_content"
-			android:layout_height="wrap_content"
-			android:layout_alignParentEnd="true"
-			android:layout_alignParentBottom="true"
-			android:layout_marginTop="12dp"
-			android:layout_marginEnd="12dp"
-			android:layout_marginBottom="12dp"
-			android:drawableStart="@drawable/ic_star_rating"
-			android:drawablePadding="4dp"
-			android:textAppearance="@style/TextAppearance.MaterialComponents.Body2"
-			tools:text="10/10" />
+			<TextView
+				android:id="@+id/textView_title"
+				android:layout_width="match_parent"
+				android:layout_height="wrap_content"
+				android:layout_marginStart="6dp"
+				android:layout_marginTop="6dp"
+				android:layout_marginEnd="6dp"
+				android:ellipsize="end"
+				android:maxLines="2"
+				android:textAppearance="@style/TextAppearance.MaterialComponents.Body1"
+				tools:text="@tools:sample/lorem[6]" />
 
-		<View
-			android:id="@+id/divider"
-			android:layout_width="match_parent"
-			android:layout_height="1dp"
-			android:layout_above="@id/textView_rating"
-			android:layout_alignParentEnd="true"
-			android:layout_toEndOf="@id/imageView_cover"
-			android:background="?android:listDivider" />
+			<TextView
+				android:id="@+id/textView_subtitle"
+				android:layout_width="match_parent"
+				android:layout_height="0dp"
+				android:layout_marginStart="6dp"
+				android:layout_marginTop="4dp"
+				android:layout_marginEnd="6dp"
+				android:layout_marginBottom="6dp"
+				android:layout_weight="1"
+				android:ellipsize="end"
+				android:maxLines="1"
+				android:textAppearance="@style/TextAppearance.MaterialComponents.Body2"
+				android:textColor="?android:textColorSecondary"
+				tools:text="@tools:sample/lorem[6]" />
 
-	</RelativeLayout>
+
+			<View
+				android:id="@+id/divider"
+				android:layout_width="match_parent"
+				android:layout_height="1dp"
+				android:background="?android:listDivider" />
+
+			<LinearLayout
+				android:layout_width="match_parent"
+				android:layout_height="wrap_content"
+				android:gravity="center_vertical"
+				android:orientation="horizontal"
+				android:paddingStart="6dp"
+				android:paddingEnd="6dp">
+
+				<TextView
+					android:id="@+id/textView_tags"
+					android:layout_width="0dp"
+					android:layout_height="wrap_content"
+					android:layout_marginTop="12dp"
+					android:layout_marginBottom="12dp"
+					android:layout_weight="1"
+					android:ellipsize="none"
+					android:gravity="center_vertical"
+					android:requiresFadingEdge="horizontal"
+					android:singleLine="true" />
+
+				<TextView
+					android:id="@+id/textView_rating"
+					android:layout_width="wrap_content"
+					android:layout_height="wrap_content"
+					android:drawableStart="@drawable/ic_star_rating"
+					android:drawablePadding="4dp"
+					android:textAppearance="@style/TextAppearance.MaterialComponents.Body2"
+					tools:text="10/10" />
+
+			</LinearLayout>
+
+		</LinearLayout>
+
+	</LinearLayout>
 
 </com.google.android.material.card.MaterialCardView>
\ No newline at end of file