From 8b295f6a9301c0c65e24e8668ecffabc0d00f925 Mon Sep 17 00:00:00 2001 From: Koitharu Date: Sun, 13 Mar 2022 17:50:49 +0200 Subject: [PATCH] Fix dialogs width --- .../kotatsu/base/ui/BaseBottomSheet.kt | 2 +- .../kotatsu/reader/ui/ReaderActivity.kt | 10 ++- .../res/layout-w600dp/activity_reader.xml | 83 +++++++++++++++++++ app/src/main/res/values/themes.xml | 8 ++ 4 files changed, 98 insertions(+), 5 deletions(-) create mode 100644 app/src/main/res/layout-w600dp/activity_reader.xml diff --git a/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseBottomSheet.kt b/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseBottomSheet.kt index d65e031fa..b2146c3ba 100644 --- a/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseBottomSheet.kt +++ b/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseBottomSheet.kt @@ -42,7 +42,7 @@ abstract class BaseBottomSheet : BottomSheetDialogFragment() { override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { return if (resources.getBoolean(R.bool.is_tablet)) { - AppCompatDialog(context, theme) + AppCompatDialog(context, R.style.Theme_Kotatsu_Dialog) } else super.onCreateDialog(savedInstanceState) } diff --git a/app/src/main/java/org/koitharu/kotatsu/reader/ui/ReaderActivity.kt b/app/src/main/java/org/koitharu/kotatsu/reader/ui/ReaderActivity.kt index cd15c2bfa..791bc316f 100644 --- a/app/src/main/java/org/koitharu/kotatsu/reader/ui/ReaderActivity.kt +++ b/app/src/main/java/org/koitharu/kotatsu/reader/ui/ReaderActivity.kt @@ -241,7 +241,7 @@ class ReaderActivity : BaseFullscreenActivity(), rawX >= binding.root.width - gestureInsets.right || rawY >= binding.root.height - gestureInsets.bottom || binding.appbarTop.hasGlobalPoint(rawX, rawY) || - binding.appbarBottom.hasGlobalPoint(rawX, rawY) + binding.appbarBottom?.hasGlobalPoint(rawX, rawY) == true ) { false } else { @@ -318,11 +318,13 @@ class ReaderActivity : BaseFullscreenActivity(), if (binding.appbarTop.isVisible != isUiVisible) { val transition = TransitionSet() .setOrdering(TransitionSet.ORDERING_TOGETHER) - .addTransition(Slide(Gravity.BOTTOM).addTarget(binding.appbarBottom)) .addTransition(Slide(Gravity.TOP).addTarget(binding.appbarTop)) + binding.appbarBottom?.let { botomBar -> + transition.addTransition(Slide(Gravity.BOTTOM).addTarget(botomBar)) + } TransitionManager.beginDelayedTransition(binding.root, transition) binding.appbarTop.isVisible = isUiVisible - binding.appbarBottom.isVisible = isUiVisible + binding.appbarBottom?.isVisible = isUiVisible if (isUiVisible) { showSystemUI() } else { @@ -339,7 +341,7 @@ class ReaderActivity : BaseFullscreenActivity(), right = systemBars.right, left = systemBars.left ) - binding.appbarBottom.updatePadding( + binding.appbarBottom?.updatePadding( bottom = systemBars.bottom, right = systemBars.right, left = systemBars.left diff --git a/app/src/main/res/layout-w600dp/activity_reader.xml b/app/src/main/res/layout-w600dp/activity_reader.xml new file mode 100644 index 000000000..90a78c533 --- /dev/null +++ b/app/src/main/res/layout-w600dp/activity_reader.xml @@ -0,0 +1,83 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index d1b29006e..a51ebf1e4 100644 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -85,4 +85,12 @@ +