Migrate to ViewBinding

app/src/main/java/org/koitharu/kotatsu/tracker/TrackerModule.kt

@@ -1,7 +1,7 @@
 package org.koitharu.kotatsu.tracker
 
 import org.koin.android.ext.koin.androidContext
-import org.koin.android.viewmodel.dsl.viewModel
+import org.koin.androidx.viewmodel.dsl.viewModel
 import org.koin.dsl.module
 import org.koitharu.kotatsu.tracker.domain.TrackingRepository
 import org.koitharu.kotatsu.tracker.ui.FeedViewModel

app/src/main/java/org/koitharu/kotatsu/tracker/ui/FeedFragment.kt

@@ -1,32 +1,29 @@
 package org.koitharu.kotatsu.tracker.ui
 
 import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
-import android.view.View
+import android.view.*
 import androidx.core.view.isVisible
 import com.google.android.material.snackbar.Snackbar
-import kotlinx.android.synthetic.main.fragment_tracklogs.*
 import org.koin.android.ext.android.get
-import org.koin.android.viewmodel.ext.android.viewModel
+import org.koin.androidx.viewmodel.ext.android.viewModel
 import org.koitharu.kotatsu.R
 import org.koitharu.kotatsu.base.ui.BaseFragment
 import org.koitharu.kotatsu.base.ui.list.OnListItemClickListener
 import org.koitharu.kotatsu.base.ui.list.PaginationScrollListener
 import org.koitharu.kotatsu.base.ui.list.decor.SpacingItemDecoration
 import org.koitharu.kotatsu.core.model.Manga
+import org.koitharu.kotatsu.databinding.FragmentFeedBinding
 import org.koitharu.kotatsu.details.ui.DetailsActivity
 import org.koitharu.kotatsu.tracker.work.TrackWorker
 import org.koitharu.kotatsu.utils.ext.getDisplayMessage
 import org.koitharu.kotatsu.utils.ext.hasItems
 
-class FeedFragment : BaseFragment(R.layout.fragment_tracklogs), PaginationScrollListener.Callback,
+class FeedFragment : BaseFragment<FragmentFeedBinding>(), PaginationScrollListener.Callback,
 	OnListItemClickListener<Manga> {
 
 	private val viewModel by viewModel<FeedViewModel>()
 
-	private var adapter: FeedAdapter? = null
+	private var feedAdapter: FeedAdapter? = null
 
 	override fun getTitle() = context?.getString(R.string.updates)
 
@@ -35,15 +32,22 @@ class FeedFragment : BaseFragment(R.layout.fragment_tracklogs), PaginationScroll
 		setHasOptionsMenu(true)
 	}
 
+	override fun onInflateView(
+		inflater: LayoutInflater,
+		container: ViewGroup?
+	) = FragmentFeedBinding.inflate(inflater, container, false)
+
 	override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
 		super.onViewCreated(view, savedInstanceState)
-		adapter = FeedAdapter(get(), this)
-		recyclerView.adapter = adapter
-		recyclerView.addItemDecoration(
-			SpacingItemDecoration(resources.getDimensionPixelOffset(R.dimen.grid_spacing))
-		)
-		recyclerView.setHasFixedSize(true)
-		recyclerView.addOnScrollListener(PaginationScrollListener(4, this))
+		feedAdapter = FeedAdapter(get(), this)
+		with(binding.recyclerView) {
+			adapter = feedAdapter
+			addItemDecoration(
+				SpacingItemDecoration(resources.getDimensionPixelOffset(R.dimen.grid_spacing))
+			)
+			setHasFixedSize(true)
+			addOnScrollListener(PaginationScrollListener(4, this@FeedFragment))
+		}
 
 		viewModel.content.observe(viewLifecycleOwner, this::onListChanged)
 		viewModel.isLoading.observe(viewLifecycleOwner, this::onLoadingStateChanged)
@@ -59,47 +63,56 @@ class FeedFragment : BaseFragment(R.layout.fragment_tracklogs), PaginationScroll
 	override fun onOptionsItemSelected(item: MenuItem) = when (item.itemId) {
 		R.id.action_update -> {
 			TrackWorker.startNow(requireContext())
-			Snackbar.make(recyclerView, R.string.feed_will_update_soon, Snackbar.LENGTH_LONG).show()
+			Snackbar.make(
+				binding.recyclerView,
+				R.string.feed_will_update_soon,
+				Snackbar.LENGTH_LONG
+			).show()
 			true
 		}
 		else -> super.onOptionsItemSelected(item)
 	}
 
 	override fun onDestroyView() {
-		adapter = null
+		feedAdapter = null
 		super.onDestroyView()
 	}
 
 	private fun onListChanged(list: List<Any>) {
-		adapter?.items = list
+		feedAdapter?.items = list
 	}
 
 	private fun onError(e: Throwable) {
-		if (recyclerView.hasItems) {
-			Snackbar.make(recyclerView, e.getDisplayMessage(resources), Snackbar.LENGTH_SHORT)
-				.show()
+		if (binding.recyclerView.hasItems) {
+			Snackbar.make(
+				binding.recyclerView,
+				e.getDisplayMessage(resources),
+				Snackbar.LENGTH_SHORT
+			).show()
 		} else {
-			textView_holder.text = e.getDisplayMessage(resources)
-			textView_holder.setCompoundDrawablesRelativeWithIntrinsicBounds(
-				0,
-				R.drawable.ic_error_large,
-				0,
-				0
-			)
-			layout_holder.isVisible = true
+			with(binding.textViewHolder) {
+				text = e.getDisplayMessage(resources)
+				setCompoundDrawablesRelativeWithIntrinsicBounds(
+					0,
+					R.drawable.ic_error_large,
+					0,
+					0
+				)
+				isVisible = true
+			}
 		}
 	}
 
 	private fun onLoadingStateChanged(isLoading: Boolean) {
-		val hasItems = recyclerView.hasItems
-		progressBar.isVisible = isLoading && !hasItems
+		val hasItems = binding.recyclerView.hasItems
+		binding.progressBar.isVisible = isLoading && !hasItems
 	}
 
 	private fun onEmptyStateChanged(isEmpty: Boolean) {
 		if (isEmpty) {
 			setUpEmptyListHolder()
 		}
-		layout_holder.isVisible = isEmpty
+		binding.layoutHolder.isVisible = isEmpty
 	}
 
 	override fun onScrolledToEnd() {
@@ -111,8 +124,10 @@ class FeedFragment : BaseFragment(R.layout.fragment_tracklogs), PaginationScroll
 	}
 
 	private fun setUpEmptyListHolder() {
-		textView_holder.setCompoundDrawablesRelativeWithIntrinsicBounds(null, null, null, null)
-		textView_holder.setText(R.string.text_feed_holder)
+		with(binding.textViewHolder) {
+			setCompoundDrawablesRelativeWithIntrinsicBounds(null, null, null, null)
+			setText(R.string.text_feed_holder)
+		}
 	}
 
 	companion object {

app/src/main/java/org/koitharu/kotatsu/tracker/ui/adapter/FeedItemAD.kt

@@ -2,11 +2,11 @@ package org.koitharu.kotatsu.tracker.ui.adapter
 
 import coil.ImageLoader
 import coil.request.Disposable
-import com.hannesdorfmann.adapterdelegates4.dsl.adapterDelegateLayoutContainer
-import kotlinx.android.synthetic.main.item_tracklog.*
+import com.hannesdorfmann.adapterdelegates4.dsl.adapterDelegateViewBinding
 import org.koitharu.kotatsu.R
 import org.koitharu.kotatsu.base.ui.list.OnListItemClickListener
 import org.koitharu.kotatsu.core.model.Manga
+import org.koitharu.kotatsu.databinding.ItemTracklogBinding
 import org.koitharu.kotatsu.tracker.ui.model.FeedItem
 import org.koitharu.kotatsu.utils.ext.enqueueWith
 import org.koitharu.kotatsu.utils.ext.newImageRequest
@@ -14,7 +14,9 @@ import org.koitharu.kotatsu.utils.ext.newImageRequest
 fun feedItemAD(
 	coil: ImageLoader,
 	clickListener: OnListItemClickListener<Manga>
-) = adapterDelegateLayoutContainer<FeedItem, Any>(R.layout.item_tracklog) {
+) = adapterDelegateViewBinding<FeedItem, Any, ItemTracklogBinding>(
+	{ inflater, parent -> ItemTracklogBinding.inflate(inflater, parent, false) }
+) {
 
 	var imageRequest: Disposable? = null
 
@@ -24,18 +26,18 @@ fun feedItemAD(
 
 	bind {
 		imageRequest?.dispose()
-		imageRequest = imageView_cover.newImageRequest(item.imageUrl)
+		imageRequest = binding.imageViewCover.newImageRequest(item.imageUrl)
 			.placeholder(R.drawable.ic_placeholder)
 			.fallback(R.drawable.ic_placeholder)
 			.error(R.drawable.ic_placeholder)
 			.enqueueWith(coil)
-		textView_title.text = item.title
-		textView_subtitle.text = item.subtitle
-		textView_chapters.text = item.chapters
+		binding.textViewTitle.text = item.title
+		binding.textViewSubtitle.text = item.subtitle
+		binding.textViewChapters.text = item.chapters
 	}
 
 	onViewRecycled {
 		imageRequest?.dispose()
-		imageView_cover.setImageDrawable(null)
+		binding.imageViewCover.setImageDrawable(null)
 	}
 }