Read button tip in DetailsActivity

app/src/main/kotlin/org/koitharu/kotatsu/details/ui/ButtonTip.kt

@@ -0,0 +1,92 @@
+package org.koitharu.kotatsu.details.ui
+
+import android.transition.TransitionManager
+import android.view.Gravity
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
+import androidx.constraintlayout.widget.ConstraintLayout
+import androidx.constraintlayout.widget.ConstraintSet
+import androidx.coordinatorlayout.widget.CoordinatorLayout
+import androidx.core.graphics.Insets
+import androidx.core.view.setMargins
+import androidx.core.view.updateLayoutParams
+import org.koitharu.kotatsu.R
+import org.koitharu.kotatsu.core.ui.util.WindowInsetsDelegate
+import org.koitharu.kotatsu.core.util.ext.getThemeDimensionPixelSize
+import org.koitharu.kotatsu.core.util.ext.isAnimationsEnabled
+import org.koitharu.kotatsu.databinding.ItemTipBinding
+import com.google.android.material.R as materialR
+
+class ButtonTip(
+	private val root: ViewGroup,
+	private val insetsDelegate: WindowInsetsDelegate,
+	private val viewModel: DetailsViewModel,
+) : View.OnClickListener, WindowInsetsDelegate.WindowInsetsListener {
+
+	private var selfBinding = ItemTipBinding.inflate(LayoutInflater.from(root.context), root, false)
+	private val actionBarSize = root.context.getThemeDimensionPixelSize(materialR.attr.actionBarSize)
+
+	init {
+		selfBinding.textView.setText(R.string.details_button_tip)
+		selfBinding.imageViewIcon.setImageResource(R.drawable.ic_tap)
+		selfBinding.root.id = R.id.layout_tip
+		selfBinding.buttonClose.setOnClickListener(this)
+	}
+
+	override fun onClick(v: View?) {
+		remove()
+	}
+
+	override fun onWindowInsetsChanged(insets: Insets) {
+		if (root is CoordinatorLayout) {
+			selfBinding.root.updateLayoutParams<CoordinatorLayout.LayoutParams> {
+				bottomMargin = topMargin + insets.bottom + insets.top + actionBarSize
+			}
+		}
+	}
+
+	fun addToRoot() {
+		val lp: ViewGroup.LayoutParams = when (root) {
+			is CoordinatorLayout -> CoordinatorLayout.LayoutParams(
+				ViewGroup.LayoutParams.MATCH_PARENT,
+				ViewGroup.LayoutParams.WRAP_CONTENT,
+			).apply {
+				// anchorId = R.id.layout_bottom
+				// anchorGravity = Gravity.TOP
+				gravity = Gravity.BOTTOM
+				setMargins(root.resources.getDimensionPixelOffset(R.dimen.margin_normal))
+				bottomMargin += actionBarSize
+			}
+
+			is ConstraintLayout -> ConstraintLayout.LayoutParams(
+				ViewGroup.LayoutParams.MATCH_PARENT,
+				ViewGroup.LayoutParams.WRAP_CONTENT,
+			).apply {
+				width = root.resources.getDimensionPixelSize(R.dimen.m3_side_sheet_width)
+				setMargins(root.resources.getDimensionPixelOffset(R.dimen.margin_normal))
+			}
+
+			else -> ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT)
+		}
+		root.addView(selfBinding.root, lp)
+		if (root is ConstraintLayout) {
+			val cs = ConstraintSet()
+			cs.clone(root)
+			cs.connect(R.id.layout_tip, ConstraintSet.TOP, R.id.appbar, ConstraintSet.BOTTOM)
+			cs.connect(R.id.layout_tip, ConstraintSet.START, R.id.card_chapters, ConstraintSet.START)
+			cs.connect(R.id.layout_tip, ConstraintSet.END, R.id.card_chapters, ConstraintSet.END)
+			cs.applyTo(root)
+		}
+		insetsDelegate.addInsetsListener(this)
+	}
+
+	fun remove() {
+		if (root.context.isAnimationsEnabled) {
+			TransitionManager.beginDelayedTransition(root)
+		}
+		insetsDelegate.removeInsetsListener(this)
+		root.removeView(selfBinding.root)
+		viewModel.onButtonTipClosed()
+	}
+}

app/src/main/kotlin/org/koitharu/kotatsu/details/ui/DetailsActivity.kt

@@ -55,6 +55,7 @@ import org.koitharu.kotatsu.main.ui.owners.NoModalBottomSheetOwner
 import org.koitharu.kotatsu.parsers.model.Manga
 import org.koitharu.kotatsu.reader.ui.ReaderActivity
 import org.koitharu.kotatsu.reader.ui.thumbnails.PagesThumbnailsSheet
+import java.lang.ref.WeakReference
 import javax.inject.Inject
 import com.google.android.material.R as materialR
 
@@ -70,6 +71,7 @@ class DetailsActivity :
 	lateinit var shortcutsUpdater: ShortcutsUpdater
 
 	private lateinit var viewBadge: ViewBadge
+	private var buttonTip: WeakReference<ButtonTip>? = null
 
 	private val viewModel: DetailsViewModel by viewModels()
 	private lateinit var chaptersMenuProvider: ChaptersMenuProvider
@@ -122,6 +124,7 @@ class DetailsActivity :
 		viewModel.onShowToast.observeEvent(this) {
 			makeSnackbar(getString(it), Snackbar.LENGTH_SHORT).show()
 		}
+		viewModel.onShowTip.observeEvent(this) { showTip() }
 		viewModel.historyInfo.observe(this, ::onHistoryChanged)
 		viewModel.selectedBranch.observe(this) {
 			viewBinding.toolbarChapters?.subtitle = it
@@ -162,6 +165,8 @@ class DetailsActivity :
 
 	override fun onLongClick(v: View): Boolean = when (v.id) {
 		R.id.button_read -> {
+			buttonTip?.get()?.remove()
+			buttonTip = null
 			val menu = PopupMenu(v.context, v)
 			menu.inflate(R.menu.popup_read)
 			menu.setOnMenuItemClickListener(this)
@@ -345,8 +350,16 @@ class DetailsActivity :
 		}
 	}
 
+	private fun showTip() {
+		val tip = ButtonTip(viewBinding.root as ViewGroup, insetsDelegate, viewModel)
+		tip.addToRoot()
+		buttonTip = WeakReference(tip)
+	}
+
 	companion object {
 
+		const val TIP_BUTTON = "btn_read"
+
 		fun newIntent(context: Context, manga: Manga): Intent {
 			return Intent(context, DetailsActivity::class.java)
 				.putExtra(MangaIntent.KEY_MANGA, ParcelableManga(manga, withChapters = true))

app/src/main/kotlin/org/koitharu/kotatsu/details/ui/DetailsViewModel.kt

@@ -18,6 +18,8 @@ import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.flow.distinctUntilChangedBy
+import kotlinx.coroutines.flow.filterNot
+import kotlinx.coroutines.flow.first
 import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.flow.map
@@ -78,6 +80,7 @@ class DetailsViewModel @Inject constructor(
 	private var loadingJob: Job
 
 	val onShowToast = MutableEventFlow<Int>()
+	val onShowTip = MutableEventFlow<Unit>()
 	val onDownloadStarted = MutableEventFlow<Unit>()
 
 	val manga = doubleManga.map { it?.any }
@@ -191,6 +194,12 @@ class DetailsViewModel @Inject constructor(
 			localStorageChanges
 				.collect { onDownloadComplete(it) }
 		}
+		launchJob(Dispatchers.Default) {
+			if (settings.isTipEnabled(DetailsActivity.TIP_BUTTON)) {
+				manga.filterNot { it?.chapters.isNullOrEmpty() }.first()
+				onShowTip.call(Unit)
+			}
+		}
 	}
 
 	fun reload() {
@@ -277,6 +286,10 @@ class DetailsViewModel @Inject constructor(
 		}
 	}
 
+	fun onButtonTipClosed() {
+		settings.closeTip(DetailsActivity.TIP_BUTTON)
+	}
+
 	private fun doLoad() = launchLoadingJob(Dispatchers.Default) {
 		val result = doubleMangaLoadUseCase(intent)
 		val manga = result.requireAny()