Fix page position loss when switching reader modes
- Compare content.state with getCurrentState() to detect configuration changes vs intentional updates - Use content.state when they match (mode switch case) to preserve explicit state updates - Use getCurrentState() when they differ (rotation case) to restore saved position - This ensures both screen rotation and mode switching work correctly Co-authored-by: NathanBap <101987516+NathanBap@users.noreply.github.com>
This commit is contained in:
committed by
Koitharu
parent
aeb3732d75
commit
5f879f6c83
@@ -25,18 +25,16 @@ abstract class BaseReaderFragment<B : ViewBinding> : BaseFragment<B>(), ZoomCont
|
||||
readerAdapter = onCreateAdapter()
|
||||
|
||||
viewModel.content.observe(viewLifecycleOwner) {
|
||||
// Use getCurrentState() to handle configuration changes (e.g., screen rotation) properly.
|
||||
// getCurrentState() always has the most recent reading position, while content.state
|
||||
// may contain the initial state from when content was first loaded.
|
||||
// Determine which state to use for restoring position:
|
||||
// - content.state: explicitly set state (e.g., after mode switch or chapter change)
|
||||
// - getCurrentState(): current reading position saved in SavedStateHandle
|
||||
val currentState = viewModel.getCurrentState()
|
||||
if (it.state == null && it.pages.isNotEmpty() && readerAdapter?.hasItems != true) {
|
||||
onPagesChanged(it.pages, currentState)
|
||||
} else if (currentState != null) {
|
||||
// If we have a current state, use it instead of content.state
|
||||
onPagesChanged(it.pages, currentState)
|
||||
} else {
|
||||
onPagesChanged(it.pages, it.state)
|
||||
val pendingState = when {
|
||||
it.state == null && it.pages.isNotEmpty() && readerAdapter?.hasItems != true -> currentState
|
||||
readerAdapter?.hasItems != true && it.state != currentState && currentState != null -> currentState
|
||||
else -> it.state
|
||||
}
|
||||
onPagesChanged(it.pages, pendingState)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user