Apply suggestions.
This commit is contained in:
committed by
Koitharu
parent
9a815f28fa
commit
46ab5af905
@@ -3,7 +3,6 @@ package org.koitharu.kotatsu.core.model.parcelable
|
||||
import android.os.Parcel
|
||||
import android.os.Parcelable
|
||||
import androidx.core.os.ParcelCompat
|
||||
import kotlinx.parcelize.IgnoredOnParcel
|
||||
import kotlinx.parcelize.Parceler
|
||||
import kotlinx.parcelize.Parcelize
|
||||
import org.koitharu.kotatsu.core.util.ext.readParcelableCompat
|
||||
@@ -17,7 +16,7 @@ private const val MAX_SAFE_CHAPTERS_COUNT = 24 // this is 100% safe
|
||||
@Parcelize
|
||||
data class ParcelableManga(
|
||||
val manga: Manga,
|
||||
@IgnoredOnParcel private val withChapters: Boolean = true,
|
||||
private val withChapters: Boolean,
|
||||
) : Parcelable {
|
||||
companion object : Parceler<ParcelableManga> {
|
||||
private fun Manga.writeToParcel(out: Parcel, flags: Int, withChapters: Boolean) {
|
||||
@@ -64,21 +63,22 @@ data class ParcelableManga(
|
||||
override fun create(parcel: Parcel) = ParcelableManga(
|
||||
Manga(
|
||||
id = parcel.readLong(),
|
||||
title = parcel.readString()!!,
|
||||
title = requireNotNull(parcel.readString()),
|
||||
altTitle = parcel.readString(),
|
||||
url = parcel.readString()!!,
|
||||
publicUrl = parcel.readString()!!,
|
||||
url = requireNotNull(parcel.readString()),
|
||||
publicUrl = requireNotNull(parcel.readString()),
|
||||
rating = parcel.readFloat(),
|
||||
isNsfw = ParcelCompat.readBoolean(parcel),
|
||||
coverUrl = parcel.readString()!!,
|
||||
coverUrl = requireNotNull(parcel.readString()),
|
||||
largeCoverUrl = parcel.readString(),
|
||||
description = parcel.readString(),
|
||||
tags = parcel.readParcelableCompat<ParcelableMangaTags>()!!.tags,
|
||||
tags = requireNotNull(parcel.readParcelableCompat<ParcelableMangaTags>()).tags,
|
||||
state = parcel.readSerializableCompat(),
|
||||
author = parcel.readString(),
|
||||
chapters = parcel.readParcelableCompat<ParcelableMangaChapters>()?.chapters,
|
||||
source = parcel.readSerializableCompat()!!,
|
||||
source = requireNotNull(parcel.readSerializableCompat()),
|
||||
),
|
||||
withChapters = true
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -11,13 +11,13 @@ import org.koitharu.kotatsu.parsers.model.MangaChapter
|
||||
object MangaChapterParceler : Parceler<MangaChapter> {
|
||||
override fun create(parcel: Parcel) = MangaChapter(
|
||||
id = parcel.readLong(),
|
||||
name = parcel.readString()!!,
|
||||
name = requireNotNull(parcel.readString()),
|
||||
number = parcel.readInt(),
|
||||
url = parcel.readString()!!,
|
||||
url = requireNotNull(parcel.readString()),
|
||||
scanlator = parcel.readString(),
|
||||
uploadDate = parcel.readLong(),
|
||||
branch = parcel.readString(),
|
||||
source = parcel.readSerializableCompat()!!,
|
||||
source = requireNotNull(parcel.readSerializableCompat()),
|
||||
)
|
||||
|
||||
override fun MangaChapter.write(parcel: Parcel, flags: Int) {
|
||||
|
||||
@@ -11,9 +11,9 @@ import org.koitharu.kotatsu.parsers.model.MangaPage
|
||||
object MangaPageParceler : Parceler<MangaPage> {
|
||||
override fun create(parcel: Parcel) = MangaPage(
|
||||
id = parcel.readLong(),
|
||||
url = parcel.readString()!!,
|
||||
url = requireNotNull(parcel.readString()),
|
||||
preview = parcel.readString(),
|
||||
source = parcel.readSerializableCompat()!!,
|
||||
source = requireNotNull(parcel.readSerializableCompat()),
|
||||
)
|
||||
|
||||
override fun MangaPage.write(parcel: Parcel, flags: Int) {
|
||||
|
||||
@@ -10,9 +10,9 @@ import org.koitharu.kotatsu.parsers.model.MangaTag
|
||||
|
||||
object MangaTagParceler : Parceler<MangaTag> {
|
||||
override fun create(parcel: Parcel) = MangaTag(
|
||||
title = parcel.readString()!!,
|
||||
key = parcel.readString()!!,
|
||||
source = parcel.readSerializableCompat()!!,
|
||||
title = requireNotNull(parcel.readString()),
|
||||
key = requireNotNull(parcel.readString()),
|
||||
source = requireNotNull(parcel.readSerializableCompat()),
|
||||
)
|
||||
|
||||
override fun MangaTag.write(parcel: Parcel, flags: Int) {
|
||||
|
||||
@@ -362,7 +362,7 @@ class DetailsActivity :
|
||||
|
||||
fun newIntent(context: Context, manga: Manga): Intent {
|
||||
return Intent(context, DetailsActivity::class.java)
|
||||
.putExtra(MangaIntent.KEY_MANGA, ParcelableManga(manga))
|
||||
.putExtra(MangaIntent.KEY_MANGA, ParcelableManga(manga, withChapters = true))
|
||||
}
|
||||
|
||||
fun newIntent(context: Context, mangaId: Long): Intent {
|
||||
|
||||
@@ -405,7 +405,7 @@ class ReaderActivity :
|
||||
.setAction(ACTION_MANGA_READ)
|
||||
|
||||
fun manga(manga: Manga) = apply {
|
||||
intent.putExtra(MangaIntent.KEY_MANGA, ParcelableManga(manga))
|
||||
intent.putExtra(MangaIntent.KEY_MANGA, ParcelableManga(manga, withChapters = true))
|
||||
}
|
||||
|
||||
fun mangaId(mangaId: Long) = apply {
|
||||
|
||||
@@ -152,7 +152,7 @@ class ColorFilterConfigActivity :
|
||||
|
||||
fun newIntent(context: Context, manga: Manga, page: MangaPage) =
|
||||
Intent(context, ColorFilterConfigActivity::class.java)
|
||||
.putExtra(EXTRA_MANGA, ParcelableManga(manga, false))
|
||||
.putExtra(EXTRA_MANGA, ParcelableManga(manga, withChapters = false))
|
||||
.putExtra(EXTRA_PAGES, ParcelableMangaPage(page))
|
||||
}
|
||||
}
|
||||
|
||||
@@ -192,7 +192,7 @@ class PagesThumbnailsSheet :
|
||||
|
||||
fun show(fm: FragmentManager, manga: Manga, chapterId: Long, currentPage: Int = -1) {
|
||||
PagesThumbnailsSheet().withArgs(3) {
|
||||
putParcelable(ARG_MANGA, ParcelableManga(manga))
|
||||
putParcelable(ARG_MANGA, ParcelableManga(manga, withChapters = true))
|
||||
putLong(ARG_CHAPTER_ID, chapterId)
|
||||
putInt(ARG_CURRENT_PAGE, currentPage)
|
||||
}.showDistinct(fm, TAG)
|
||||
|
||||
Reference in New Issue
Block a user