From 12e9fb5aab8d6ce63c6c629891f95b8a19ce40b2 Mon Sep 17 00:00:00 2001 From: Koitharu Date: Sat, 6 May 2023 17:41:15 +0300 Subject: [PATCH] Fix download error with empty largeCoverUrl --- .../koitharu/kotatsu/download/domain/DownloadManager.kt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/koitharu/kotatsu/download/domain/DownloadManager.kt b/app/src/main/java/org/koitharu/kotatsu/download/domain/DownloadManager.kt index 3d5b3c46d..88f4a6aa0 100644 --- a/app/src/main/java/org/koitharu/kotatsu/download/domain/DownloadManager.kt +++ b/app/src/main/java/org/koitharu/kotatsu/download/domain/DownloadManager.kt @@ -41,6 +41,7 @@ import org.koitharu.kotatsu.parsers.model.MangaSource import org.koitharu.kotatsu.parsers.util.await import org.koitharu.kotatsu.utils.ext.copyToSuspending import org.koitharu.kotatsu.utils.ext.deleteAwait +import org.koitharu.kotatsu.utils.ext.ifNullOrEmpty import org.koitharu.kotatsu.utils.ext.printStackTraceDebug import org.koitharu.kotatsu.utils.ext.runCatchingCancellable import org.koitharu.kotatsu.utils.progress.PausingProgressJob @@ -124,9 +125,11 @@ class DownloadManager @Inject constructor( outState.value = DownloadState.Preparing(startId, manga, cover) val data = if (manga.chapters.isNullOrEmpty()) repo.getDetails(manga) else manga output = LocalMangaOutput.getOrCreate(destination, data) - val coverUrl = data.largeCoverUrl ?: data.coverUrl - downloadFile(coverUrl, destination, tempFileName, repo.source).let { file -> - output.addCover(file, MimeTypeMap.getFileExtensionFromUrl(coverUrl)) + val coverUrl = data.largeCoverUrl.ifNullOrEmpty { data.coverUrl } + if (coverUrl.isNotEmpty()) { + downloadFile(coverUrl, destination, tempFileName, repo.source).let { file -> + output.addCover(file, MimeTypeMap.getFileExtensionFromUrl(coverUrl)) + } } val chapters = checkNotNull( if (chaptersIdsSet == null) {